dimas-b commented on code in PR #2653:
URL: https://github.com/apache/polaris/pull/2653#discussion_r2379878857
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/models/SchemaVersion.java:
##########
@@ -25,6 +25,8 @@
import org.apache.polaris.persistence.relational.jdbc.DatabaseType;
public class SchemaVersion implements Converter<SchemaVersion> {
+ public static final SchemaVersion MINIMUM = new SchemaVersion(0);
Review Comment:
I do not think we have any formal requirement for the schema versions to be
comparable to each other numerically.
Current JDBC Persistence code makes some numerical comparisons, but I tend
to think that this is an implementation concern. As long as the interpretation
of schema version numbers is consistent with the schemas themselves, the code
is fine.
With that in mind, using `0` for missing schema information should produce
correct runtime behaviour, as far as I can tell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
