eric-maynard commented on code in PR #2696:
URL: https://github.com/apache/polaris/pull/2696#discussion_r2383144493
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java:
##########
@@ -124,6 +125,7 @@ public Response createCatalog(
Catalog catalog = request.getCatalog();
validateStorageConfig(catalog.getStorageConfigInfo());
validateExternalCatalog(catalog);
+ validateCatalogProperties(catalog.getProperties());
Review Comment:
Do we really want to control whether or not you can _set_ the property? Or
do we want to control whether or not the property gets respected?
_(Let `ALLOW_SETTING_SUB_CATALOG_RBAC_FOR_FEDERATED_CATALOGS` be `C`)_
In other words, is it a valid use case that I start with `C` as true, then
configure RBAC on some table in a federated catalog, then I set `C` to false,
but the RBAC settings on my table still apply? When is that preferable to just
ignoring the table's RBAC settings once `C` is set to false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
