eric-maynard commented on code in PR #2696:
URL: https://github.com/apache/polaris/pull/2696#discussion_r2383144493
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java:
##########
@@ -124,6 +125,7 @@ public Response createCatalog(
Catalog catalog = request.getCatalog();
validateStorageConfig(catalog.getStorageConfigInfo());
validateExternalCatalog(catalog);
+ validateCatalogProperties(catalog.getProperties());
Review Comment:
Do we really want to control whether or not you can _set_ the property? Or
do we want to control whether or not RBAC settings can be applied / will get
respected?
_(Let `ALLOW_SETTING_SUB_CATALOG_RBAC_FOR_FEDERATED_CATALOGS` be `C`)_
In other words, is it the intended use case that I can start with `C` as
true, set `ENABLE_SUB_CATALOG_RBAC_FOR_FEDERATED_CATALOGS` on my catalog, then
set `C` to false, and later continue to change RBAC settings within my catalog?
When is this preferable to `C` just meaning that RBAC settings within my
catalog no longer apply or can no longer be changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
