eric-maynard commented on code in PR #2696:
URL: https://github.com/apache/polaris/pull/2696#discussion_r2388745590
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java:
##########
@@ -124,6 +125,7 @@ public Response createCatalog(
Catalog catalog = request.getCatalog();
validateStorageConfig(catalog.getStorageConfigInfo());
validateExternalCatalog(catalog);
+ validateCatalogProperties(catalog.getProperties());
Review Comment:
I think you're right that there's a more general gap in the flag framework
and that it might be nice to be able to, for example, configure a catalog such
that no catalog overrides apply to it or can be set on it. What @dimas-b wrote
in your linked comment makes sense to me.
But what's being done here is specific to one setting... creating a second
flag for every flag where we want this level of control seems like a bad
precedent to set. Further, in this context, the message used in the
implementation (`Explicitly setting %s is not allowed.`) seems a little
unhelpful. Why is it not allowed? Is there a setting I can change to make it
allowed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
