XN137 commented on code in PR #2518:
URL: https://github.com/apache/polaris/pull/2518#discussion_r2391499114
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/dao/entity/CreatePrincipalResult.java:
##########
@@ -67,10 +71,22 @@ private CreatePrincipalResult(
super(returnStatus, extraInformation);
this.principal = principal;
this.principalSecrets = principalSecrets;
+ validate();
Review Comment:
OK i've now removed the `validate()` method as it mostly made sense to get
called in this json ctor imo.
note that due the change in `getPrincipal` the returned entity now passes
through validation of `PrincipalEntity.of` so if there is an error about the
entity being invalid it just got moved from the ctor to the `getPrincipal`
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
