dimas-b commented on code in PR #2518:
URL: https://github.com/apache/polaris/pull/2518#discussion_r2388199448
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##########
@@ -194,7 +194,7 @@ Page<PolarisBaseEntity> loadEntities(
*/
@Nonnull
CreatePrincipalResult createPrincipal(
- @Nonnull PolarisCallContext callCtx, @Nonnull PolarisBaseEntity
principal);
+ @Nonnull PolarisCallContext callCtx, @Nonnull PrincipalEntity principal);
Review Comment:
Thanks for the email, @XN137!
Given that the PR has been in review for 3 weeks, I think waiting for a
couple of days after the `dev` email should be enough to get feedback from
people who might have missed the GH notifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
