HonahX commented on code in PR #2784:
URL: https://github.com/apache/polaris/pull/2784#discussion_r2421276984
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -429,4 +429,13 @@ public static void enforceFeatureEnabledOrThrow(
"When true, enables finer grained update table privileges which
are passed to the authorizer for update table operations")
.defaultValue(true)
.buildFeatureConfiguration();
+
+ public static final FeatureConfiguration<Boolean>
ALLOW_FEDERATED_CATALOGS_CREDENTIAL_VENDING =
Review Comment:
Good suggestions! We may still want this new config but may need to scope it
differently. Ideally we should let `ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING`
only controls the behavior of `static-facade` EXTERNAL catalog and let
`ALLOW_FEDERATED_CATALOGS_CREDENTIAL_VENDING` controls the behavior of
`passthrough-facade` EXTERNAL catalog, since the implication of credential
vending is different in these 2 cases. But that will be a behavior change and
we'd better address that in a follow-up. I will drive that to make sure we
stabilize this before 1.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
