flyrain commented on code in PR #2784:
URL: https://github.com/apache/polaris/pull/2784#discussion_r2417743563
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -808,7 +809,10 @@ private LoadTableResponse.Builder
buildLoadTableResponseWithDelegationCredential
PolarisResolvedPathWrapper resolvedStoragePath =
CatalogUtils.findResolvedStorageEntity(resolutionManifest,
tableIdentifier);
- if (baseCatalog instanceof IcebergCatalog && resolvedStoragePath != null) {
+ if ((baseCatalog instanceof IcebergCatalog
+ || realmConfig.getConfig(
+ ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING,
getResolvedCatalogEntity()))
Review Comment:
My concern is that users may not understand this behavior changes, it may
confuse users even more, like what's the previous behavior? Is that supposed to
be there already? Of course, we can explain it clearly in the changelog. I'm
fine either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
