flyrain commented on code in PR #2784:
URL: https://github.com/apache/polaris/pull/2784#discussion_r2417711252
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -808,7 +809,10 @@ private LoadTableResponse.Builder
buildLoadTableResponseWithDelegationCredential
PolarisResolvedPathWrapper resolvedStoragePath =
CatalogUtils.findResolvedStorageEntity(resolutionManifest,
tableIdentifier);
- if (baseCatalog instanceof IcebergCatalog && resolvedStoragePath != null) {
+ if ((baseCatalog instanceof IcebergCatalog
+ || realmConfig.getConfig(
+ ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING,
getResolvedCatalogEntity()))
Review Comment:
Good question. I'd prefer not, this PR seems a mix of bug fix and new
feature, as we didn't clarify the behavior before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
