singhpk234 commented on code in PR #2714:
URL: https://github.com/apache/polaris/pull/2714#discussion_r2392964531
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/models/Converter.java:
##########
@@ -35,10 +35,10 @@ public interface Converter<T> {
T fromResultSet(ResultSet rs) throws SQLException;
/**
- * Convert a model into a Map with keys as snake case names, where as values
as values of member
- * of model obj.
+ * Convert a model into a Map with keys as snake case names, and values as
values of member of
+ * model obj.
*/
- Map<String, Object> toMap(DatabaseType databaseType);
+ Map<String, Object> toMap(DatabaseType databaseType, int schemaVersion);
Review Comment:
i agree, though this would mean carrying a derived column in the model
considering this i added this to the signature of this interface, please let me
know if you feel strongly about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
