flyrain commented on code in PR #2714:
URL: https://github.com/apache/polaris/pull/2714#discussion_r2392926061
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ProductionReadinessChecks.java:
##########
@@ -302,4 +302,36 @@ public ProductionReadinessCheck
checkInsecureStorageSettings(
? ProductionReadinessCheck.OK
: ProductionReadinessCheck.of(errors.toArray(new Error[0]));
}
+
+ @Produces
+ public ProductionReadinessCheck checkOverlappingSiblingCheckSettings(
+ FeaturesConfiguration featureConfiguration) {
+ var optimizedSiblingCheck = FeatureConfiguration.OPTIMIZED_SIBLING_CHECK;
+ var errors = new ArrayList<Error>();
+ if
(Boolean.parseBoolean(featureConfiguration.defaults().get(optimizedSiblingCheck.key())))
{
Review Comment:
It's fine to enable this when schema version is larger or equals to 2. In
that case, we might need an input for schema version, which I'm not sure if
it's possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
