singhpk234 commented on code in PR #2714:
URL: https://github.com/apache/polaris/pull/2714#discussion_r2393317404
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ProductionReadinessChecks.java:
##########
@@ -302,4 +302,36 @@ public ProductionReadinessCheck
checkInsecureStorageSettings(
? ProductionReadinessCheck.OK
: ProductionReadinessCheck.of(errors.toArray(new Error[0]));
}
+
+ @Produces
+ public ProductionReadinessCheck checkOverlappingSiblingCheckSettings(
+ FeaturesConfiguration featureConfiguration) {
+ var optimizedSiblingCheck = FeatureConfiguration.OPTIMIZED_SIBLING_CHECK;
+ var errors = new ArrayList<Error>();
+ if
(Boolean.parseBoolean(featureConfiguration.defaults().get(optimizedSiblingCheck.key())))
{
+ errors.add(
+ Error.ofSevere(
+ "This setting is not recommended for production environments as
it may lead to incorrect behavior, due to missing data for
location_without_scheme column in case of migrating from older Polaris
versions."
Review Comment:
I was thinking about it, but didn't find a way to detect the upgrade here as
it may happen on bootstrapped with v1 schema and then upgraded to v2 schema by
adding column, in this case the schema will contain v2 only but its a migrated
case, hence disabling it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
