snazy commented on code in PR #2735:
URL: https://github.com/apache/polaris/pull/2735#discussion_r2394046097
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1566,14 +1566,44 @@ public void doCommit(TableMetadata base, TableMetadata
metadata) {
"Generic table with same name already exists: %s",
tableIdentifier);
}
}
+ Map<String, String> storedProperties = new HashMap<>();
Review Comment:
Nit: possibly more readable when the construction of `storedProperties` is
moved to a separate `static` function in `IcebergCatalog`.
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1566,14 +1566,44 @@ public void doCommit(TableMetadata base, TableMetadata
metadata) {
"Generic table with same name already exists: %s",
tableIdentifier);
}
}
+ Map<String, String> storedProperties = new HashMap<>();
+ storedProperties.put("location", metadata.location());
Review Comment:
Mind introducing constants for the property keys? Would be helpful to avoid
typos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
