collado-mike commented on code in PR #2735:
URL: https://github.com/apache/polaris/pull/2735#discussion_r2403269535
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1566,14 +1566,19 @@ public void doCommit(TableMetadata base, TableMetadata
metadata) {
"Generic table with same name already exists: %s",
tableIdentifier);
}
}
+ Map<String, String> storedProperties =
buildTableMetadataPropertiesMap(metadata);
IcebergTableLikeEntity entity =
IcebergTableLikeEntity.of(resolvedPath == null ? null :
resolvedPath.getRawLeafEntity());
String existingLocation;
if (null == entity) {
existingLocation = null;
entity =
new IcebergTableLikeEntity.Builder(
- PolarisEntitySubType.ICEBERG_TABLE, tableIdentifier,
newLocation)
+ PolarisEntitySubType.ICEBERG_TABLE,
+ tableIdentifier,
+ Map.of(),
Review Comment:
Yeah, I was thinking about making `metadataLocation` and other settable map
entries into distinct fields in the Builder so that they can just be added to
the map in the `build` call, but... yeah, a future PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
