MonkeyCanCode commented on code in PR #2798:
URL: https://github.com/apache/polaris/pull/2798#discussion_r2443525227
##########
client/python/cli/command/catalogs.py:
##########
@@ -268,6 +273,14 @@ def _build_connection_config_info(self):
service_identity=service_identity,
remote_catalog_name=self.iceberg_remote_catalog_name
)
+ elif self.catalog_connection_type == CatalogConnectionType.HIVE.value:
+ config = HiveConnectionConfigInfo(
+ connection_type=self.catalog_connection_type.upper(),
+ uri=self.catalog_uri,
+ authentication_parameters=auth_params,
+ service_identity=service_identity,
+ warehouse=self.hadoop_warehouse
Review Comment:
Sry for the late response. I was away for couple of days. I don't have a
strong preference over this naming. Maybe ask @eric-maynard as he initially
added it in
https://github.com/apache/polaris/commit/eb6b6ad50f33d0ac73c92753063438dcf428c9db.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
