eric-maynard commented on code in PR #2798:
URL: https://github.com/apache/polaris/pull/2798#discussion_r2521617946
##########
client/python/cli/command/catalogs.py:
##########
@@ -114,6 +114,11 @@ def validate(self):
if self.catalog_connection_type ==
CatalogConnectionType.HADOOP.value:
if not self.hadoop_warehouse or not self.catalog_uri:
raise Exception(f"Missing required argument for
connection type 'HADOOP':"
+ f"
{Argument.to_flag_name(Arguments.HADOOP_WAREHOUSE)}"
+ f" and
{Argument.to_flag_name(Arguments.CATALOG_URI)}")
+ elif self.catalog_connection_type ==
CatalogConnectionType.HIVE.value:
+ if not self.hadoop_warehouse or not self.catalog_uri:
+ raise Exception(f"Missing required argument for
connection type 'HIVE':"
Review Comment:
nit: `--help` was updated to list `iceberg-rest, hadoop, hive` so these logs
(and the tests) should follow that same convention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
