eric-maynard commented on code in PR #2798:
URL: https://github.com/apache/polaris/pull/2798#discussion_r2521612297
##########
client/python/cli/command/catalogs.py:
##########
@@ -268,6 +273,14 @@ def _build_connection_config_info(self):
service_identity=service_identity,
remote_catalog_name=self.iceberg_remote_catalog_name
)
+ elif self.catalog_connection_type == CatalogConnectionType.HIVE.value:
+ config = HiveConnectionConfigInfo(
+ connection_type=self.catalog_connection_type.upper(),
+ uri=self.catalog_uri,
+ authentication_parameters=auth_params,
+ service_identity=service_identity,
+ warehouse=self.hadoop_warehouse
Review Comment:
to be clear I'm supportive of re-using these flags across federations types
(e.g. across Hive / Hadoop) and indeed I think if we ever flesh out federation
in the way that I envisioned at this time we would need to. There would be a
way to federate to a Hive catalog both for Iceberg and non-Iceberg tables, and
these would surely share arguments.
My only hesitation would be that the CLI 's method of handling arguments is
a bit brittle and if we re-use them we should just make sure the parsing and
the `--help` display behave the way we expect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
