snazy commented on code in PR #2383:
URL: https://github.com/apache/polaris/pull/2383#discussion_r2451871375
##########
.github/workflows/gradle.yml:
##########
@@ -30,7 +30,7 @@ on:
push:
branches: [ "main" ]
pull_request:
- branches: [ "main" ]
+ branches: [ "main", "release/*" ]
Review Comment:
@jbonofre these changes only let CI run against those branches, those are
not protected via `.asf.yaml`'s `github.protected_branches`.
NB: (about release-branches-protection) IMO changes to a release branch
should be minimal compared to the `main` branch. If we ever do point-releases
and consider some release an LTS release, we should apply the same level of
protection to such a branch as we do for `main`. The more commits are on a
release-branch, the more has to be verified for every release. Being confident
that the changes went through a "standard" review process and pass CI is
crucial IMO. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
