pingtimeout commented on code in PR #2383:
URL: https://github.com/apache/polaris/pull/2383#discussion_r2451883031
##########
.github/workflows/gradle.yml:
##########
@@ -30,7 +30,7 @@ on:
push:
branches: [ "main" ]
pull_request:
- branches: [ "main" ]
+ branches: [ "main", "release/*" ]
Review Comment:
@jbonofre well, if you check [release-2-update-release-candidate.yml
L131-L135](https://github.com/apache/polaris/pull/2383/files#diff-b48bf3b0ffc794c60c5c47deb82b150e3b440785ebde41cd2a32f1d7e191b4f9R131-R135),
you can see that RC can only be drafted from commits that have been validated
by CI. This is so that we do not introduce any issue with a bad cherry-pick.
Removing the `release/*` part that you highlighted would change that. And I
believe this is one of the main features from #485 that @snazy wanted me to
keep.
Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
