singhpk234 commented on code in PR #3352:
URL: https://github.com/apache/polaris/pull/3352#discussion_r2662489115
##########
persistence/relational-jdbc/src/main/resources/cockroachdb/schema-v1.sql:
##########
Review Comment:
I thought about the same though it make it a bit tricky in sense where we
take schema as part of bootstrap, hence thought its better to keep it v1
thought the contents are of v3 sql (as it would just have v3 no v1 / v2).
I additionally also thought how about we do this
ALTER COLUMN FROM INT to INT4 to make it work with existing pg version
scripts but it seems like we the feature to enable this
```
Caused by: java.sql.SQLException: Failed due to 'ERROR: ALTER COLUMN TYPE
from int to int4 is only supported experimentally
Hint: See: https://go.crdb.dev/issue-v/49329/v24.3
```
apparently
```
SET experimental_enable_alter_column_type_general = true;
ALTER TABLE your_table_name ALTER COLUMN your_column_name TYPE INT4;
```
setting this flag would be confusing.
Considering we are above i resorted to v1 name, please let me know your
thoughts considering above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
