singhpk234 commented on code in PR #3352: URL: https://github.com/apache/polaris/pull/3352#discussion_r2662527284
########## persistence/relational-jdbc/src/main/resources/cockroachdb/schema-v1.sql: ########## Review Comment: No worries at all (apologies for not being clear), what i meant is what happens some one does bootstrap with v2 in this case, since we give schema version as arg for bootstrapping https://github.com/apache/polaris/blob/4cf09ec77c77e01fc4b375c635b11a9e474b1281/persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBootstrapUtils.java#L31 may be we can abstract from the user in the handling ? secondly can be confusing why there is no v1 / v2 unlike other persistence impl. I believe when we add mariadb / mysql support we would have to work with an assumption that the column name are same and types (for example JSONB vs JSON) are handled accordingly so i just thought of starting fresh with v1 for cockroach which is exactly same as v3 of postgres schema. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
