adutra commented on PR #3340: URL: https://github.com/apache/polaris/pull/3340#issuecomment-3715881198
@flyrain the CI failure is an interesting one. After some investigation, it seems related to the colored output that we have by default when running server tests: https://github.com/apache/polaris/blob/c4fc848bce5990ab44151980916a0c704696b79b/runtime/defaults/src/main/resources/application-test.properties#L28 Quarkus CLI tests seem unable to capture colored output properly. This can be fixed in two ways: by removing the colored output completely for all tests (but that's frustrating) – or by implementing `getConfigProfile()` in `RelationalJdbcAdminProfile` and using another profile than `test`: ```java public class RelationalJdbcAdminProfile extends RelationalJdbcProfile { @Override public Map<String, String> getConfigOverrides() {...} @Override public List<TestResourceEntry> testResources() {...} // ADD THIS @Override public String getConfigProfile() { return "cli"; } } ``` The above will make the test run under the `cli` profile and thus solves the issue. (We might end up needing a `cli-test` profile one day...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
