adutra commented on code in PR #3340:
URL: https://github.com/apache/polaris/pull/3340#discussion_r2665945682
##########
runtime/defaults/src/main/resources/application.properties:
##########
@@ -293,3 +293,15 @@ quarkus.index-dependency.protobuf.artifact-id=protobuf-java
# force the locale, just in case the system's using another default locale
quarkus.default-locale=en_US
+# ---- CLI Mode Configuration (activated via -Dquarkus.profile=cli) ----
+# CLI-specific settings for admin tool commands
+%cli.quarkus.application.name=Apache Polaris Admin Tool (incubating)
+%cli.quarkus.banner.enabled=false
+%cli.quarkus.log.level=WARN
+%cli.quarkus.log.category."io.quarkus".level=ERROR
+%cli.quarkus.log.category."io.quarkus.agroal.deployment".level=ERROR
Review Comment:
nit: unnecessary.
```suggestion
```
##########
runtime/defaults/src/main/resources/application.properties:
##########
@@ -293,3 +293,15 @@ quarkus.index-dependency.protobuf.artifact-id=protobuf-java
# force the locale, just in case the system's using another default locale
quarkus.default-locale=en_US
+# ---- CLI Mode Configuration (activated via -Dquarkus.profile=cli) ----
+# CLI-specific settings for admin tool commands
+%cli.quarkus.application.name=Apache Polaris Admin Tool (incubating)
+%cli.quarkus.banner.enabled=false
+%cli.quarkus.log.level=WARN
+%cli.quarkus.log.category."io.quarkus".level=ERROR
+%cli.quarkus.log.category."io.quarkus.agroal.deployment".level=ERROR
+%cli.quarkus.log.category."org.hibernate.validator".level=ERROR
+%cli.quarkus.log.category."org.apache.polaris.service.config.ServiceProducers".level=ERROR
Review Comment:
Rather than silencing the whole class, I'd suggest modifying the
`maybeBootstrap` method as follows:
```java
public void maybeBootstrap(
@Observes Startup event,
MetaStoreManagerFactory factory,
PersistenceConfiguration config,
RealmContextConfiguration realmContextConfiguration) {
if (ConfigUtils.isProfileActive("cli")) {
return; // never bootstrap realms in CLI profile
}
...
```
I'd also suggest moving this method to a separate class, as it is becoming
quite big and complex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
