dimas-b commented on code in PR #3488:
URL: https://github.com/apache/polaris/pull/3488#discussion_r2718150742
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1800,27 +1817,23 @@ public void doRefresh() {
new AttributeMap()
.put(EventAttributes.CATALOG_NAME, catalogName)
.put(EventAttributes.VIEW_IDENTIFIER, identifier)));
+ // Create FileIO once outside the retry lambda to avoid redundant
storage requests
Review Comment:
Same concern here - not re-creating FileIO is good, but I do not think it
relates to duplicate storage requests...
To be completely clear wrt #3061, WDYT about making the FileIO optimization
change in a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
