evindj commented on code in PR #3488:
URL: https://github.com/apache/polaris/pull/3488#discussion_r2718667001
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1800,27 +1817,23 @@ public void doRefresh() {
new AttributeMap()
.put(EventAttributes.CATALOG_NAME, catalogName)
.put(EventAttributes.VIEW_IDENTIFIER, identifier)));
+ // Create FileIO once outside the retry lambda to avoid redundant
storage requests
Review Comment:
I can move the FileIO optimization to a separate PR. let me remove then here.
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -810,6 +812,24 @@ protected ViewOperations newViewOps(TableIdentifier
identifier) {
return new BasePolarisViewOperations(catalogFileIO, identifier);
}
+ /**
+ * Override to fix a bug in {@link BaseMetastoreViewCatalog#loadView} where
{@link #newViewOps} is
Review Comment:
yeah, it is my understanding that this would not happen for LoadTable,
because loadtable directly uses the operations from the table to construct the
response. See
https://github.com/apache/polaris/blob/main/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java#L387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
