dimas-b commented on code in PR #3488:
URL: https://github.com/apache/polaris/pull/3488#discussion_r2718739254
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1395,11 +1415,11 @@ public void doRefresh() {
SHOULD_RETRY_REFRESH_PREDICATE,
getMaxMetadataRefreshRetries(),
metadataLocation -> {
- String latestLocationDir =
- latestLocation.substring(0, latestLocation.lastIndexOf('/'));
// TODO: Once we have the "current" table properties pulled into
the resolvedEntity
// then we should use the actual current table properties for IO
refresh here
// instead of the general tableDefaultProperties.
+ String latestLocationDir =
+ latestLocation.substring(0, latestLocation.lastIndexOf('/'));
Review Comment:
one last thing, please - would you mind removing these changes now that
there are not necessary for the purpose of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
