adutra commented on code in PR #3456:
URL: https://github.com/apache/polaris/pull/3456#discussion_r2721795592


##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -1092,6 +1098,10 @@ public void commitTransaction(CommitTransactionRequest 
commitTransactionRequest)
               if (!updatedMetadata.changes().isEmpty()) {
                 tableOps.commit(currentMetadata, updatedMetadata);
               }
+
+              LoadTableResponse loadTableResponse =
+                  
LoadTableResponse.builder().withTableMetadata(updatedMetadata).build();

Review Comment:
   > are you both suggesting that we change the event's required attributes to 
take in the TableMetadata object instead? 
   
   Yes I was thinking about that 👍 Not sure about @dimas-b though 😅 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to