dimas-b commented on code in PR #3409:
URL: https://github.com/apache/polaris/pull/3409#discussion_r2756107974
##########
runtime/service/src/main/java/org/apache/polaris/service/storage/StorageConfiguration.java:
##########
@@ -43,19 +45,35 @@ public interface StorageConfiguration extends
S3AccessConfig {
Duration DEFAULT_TOKEN_LIFESPAN = Duration.ofHours(1);
- /**
- * The AWS access key to use for authentication. If not present, the default
credentials provider
- * chain will be used.
- */
- @WithName("aws.access-key")
- Optional<String> awsAccessKey();
Review Comment:
It might be worth keeping this old method name for backward compatibility
(and redirect the the new lookup logic)... since it's a "core" class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
