dimas-b commented on code in PR #3409:
URL: https://github.com/apache/polaris/pull/3409#discussion_r2756396252


##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageConfigurationInfo.java:
##########
@@ -105,6 +107,17 @@ public String serialize() {
     }
   }
 
+  public Optional<String> resolveStorageName() {
+    if (getAllowedLocations().isEmpty()) {
+      return Optional.empty();
+    }
+    try {
+      return Optional.ofNullable(new 
URI(getAllowedLocations().get(0)).getHost());

Review Comment:
   1) Illegal in what sense? AWS SDK accepts locations that `java.net.URI` does 
not accept :shrug: If those locations are generated by code before being used 
in Polaris, anything that the SDK accepts is possible.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to