tokoko commented on code in PR #3409:
URL: https://github.com/apache/polaris/pull/3409#discussion_r2756141109
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageConfigurationInfo.java:
##########
@@ -105,6 +107,17 @@ public String serialize() {
}
}
+ public Optional<String> resolveStorageName() {
+ if (getAllowedLocations().isEmpty()) {
+ return Optional.empty();
+ }
+ try {
+ return Optional.ofNullable(new
URI(getAllowedLocations().get(0)).getHost());
Review Comment:
should i switch to some sort of substring magic instead? I was hoping to
rely on the fact that 1) it's unlikely that root allowed locations will contain
illegal characters and 2) users can set the name explicitly as a last resort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
