dimas-b commented on code in PR #3694:
URL: https://github.com/apache/polaris/pull/3694#discussion_r2783428630
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -164,7 +165,8 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
- @SuppressWarnings("deprecation")
+ @SuppressWarnings(
+ "deprecation") // catalogConfigUnsafe() is deprecated, not the feature
config itself
Review Comment:
optional: IMHO, it would make sense to deprecate `catalogConfigUnsafe()`
only when `polaris-core` has not use cases for it.
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -164,7 +165,8 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
- @SuppressWarnings("deprecation")
+ @SuppressWarnings(
+ "deprecation") // catalogConfigUnsafe() is deprecated, not the feature
config itself
Review Comment:
optional: IMHO, it would make sense to deprecate `catalogConfigUnsafe()`
only when `polaris-core` has no use cases for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
