dimas-b commented on code in PR #3694:
URL: https://github.com/apache/polaris/pull/3694#discussion_r2784115970
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -164,7 +165,8 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
- @SuppressWarnings("deprecation")
+ @SuppressWarnings(
+ "deprecation") // catalogConfigUnsafe() is deprecated, not the feature
config itself
Review Comment:
The "problem" this PR attempts to fix, exists because
`catalogConfigUnsafe()` is deprecated in the first place. Since we all agree
that it should not be deprecated, lets un-deprecate it and then doc changes are
not necessary.
Renaming can happen later, I suppose, but could be done together with
un-deprecation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
