adutra commented on code in PR #3694:
URL: https://github.com/apache/polaris/pull/3694#discussion_r2783769432
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -164,7 +165,8 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
- @SuppressWarnings("deprecation")
+ @SuppressWarnings(
+ "deprecation") // catalogConfigUnsafe() is deprecated, not the feature
config itself
Review Comment:
I've always advocated for un-deprecating this method: what is deprecated is
the property name, not the method that we use to handle deprecated names.
I doubt the method will ever disappear: more property names could be
deprecated in the future. The current method name `catalogConfigUnsafe` focuses
on one specific case of deprecated names that happened a while ago; I would
actually rename it to `deprecatedCatalogConfig` and un-deprecate it.
My 2 cents 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
