sungwy commented on code in PR #3681:
URL: https://github.com/apache/polaris/pull/3681#discussion_r2796299314
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java:
##########
@@ -908,4 +913,75 @@ public boolean hasTransitivePrivilege(
resolvedPath);
return false;
}
+
+ @Override
+ public void preAuthorize(
+ @Nonnull AuthorizationCallContext ctx, @Nonnull AuthorizationRequest
request) {
+ PolarisResolutionManifest manifest = ctx.getResolutionManifest();
+ if (manifest.hasResolution()) {
+ return;
+ }
Review Comment:
+10000
I agree @dimas-b . I think we need to define the persistence contract asap :)
Otherwise it's going to be hard to expect consistent behaviors from all of
the call sites in the longer term
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
