sungwy commented on code in PR #3681:
URL: https://github.com/apache/polaris/pull/3681#discussion_r2796311761
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/common/CatalogUtils.java:
##########
@@ -45,13 +47,19 @@ public class CatalogUtils {
*/
public static PolarisResolvedPathWrapper findResolvedStorageEntity(
PolarisResolutionManifestCatalogView resolvedEntityView, TableIdentifier
tableIdentifier) {
+ PolarisSecurable tableSecurable =
+ new PolarisSecurable(
+ PolarisEntityType.TABLE_LIKE,
+ PolarisCatalogHelpers.tableIdentifierToList(tableIdentifier));
PolarisResolvedPathWrapper resolvedTableEntities =
resolvedEntityView.getResolvedPath(
- tableIdentifier, PolarisEntityType.TABLE_LIKE,
PolarisEntitySubType.ICEBERG_TABLE);
+ tableSecurable, PolarisEntityType.TABLE_LIKE,
PolarisEntitySubType.ICEBERG_TABLE);
Review Comment:
> is it because you plan to deprecate/remove lookup keys that are not
PolarisSecurable instances later on?
Hi @adutra - yes that was my original intention. I thought it would be a
good idea to make use of `PolarisSecurable` instead of the existing
heterogeneous object types. However, based on the concerns you raised around
introducing changes to compensate for the complexity in potentially introducing
an alias that could result in a cache-miss, I think removing `PolarisSecurable`
from `PolarisResolutionManifest` calls would be a better approach for now.
https://github.com/apache/polaris/pull/3681/changes#r2796290376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
