sungwy commented on code in PR #3681:
URL: https://github.com/apache/polaris/pull/3681#discussion_r2796302440
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizer.java:
##########
@@ -27,14 +27,36 @@
/** Interface for invoking authorization checks. */
public interface PolarisAuthorizer {
+ /**
+ * Pre-authorization hook for resolving authorizer-specific inputs.
+ *
+ * <p>Implementations may resolve or validate any inputs needed to make an
authorization decision.
+ */
+ void preAuthorize(@Nonnull AuthorizationState ctx, @Nonnull
AuthorizationRequest request);
+ /** Core authorization entry point for the new SPI. */
+ void authorize(@Nonnull AuthorizationState ctx, @Nonnull
AuthorizationRequest request);
+
+ /**
+ * Backwards-compatible external API that throws on deny for legacy call
sites.
+ *
+ * <p>Default implementation delegates to {@link
#authorize(AuthorizationState,
+ * AuthorizationRequest)}.
+ */
+ default void authorizeOrThrow(
Review Comment:
This is an artifact an intermediate state - let me clean this up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
