adutra commented on code in PR #3729:
URL: https://github.com/apache/polaris/pull/3729#discussion_r2932580567
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/iceberg/IcebergRestConnectionConfigInfoDpo.java:
##########
@@ -100,6 +125,7 @@ public ConnectionConfigInfo asConnectionConfigInfoModel(
serviceIdentityInfoDpo ->
serviceIdentityInfoDpo.asServiceIdentityInfoModel(serviceIdentityProvider))
.orElse(null))
+ .setAdditionalHeaders(getConfigs())
Review Comment:
FWIW `additionalHeaders` sounds more appropriate, and would save us from
having to probe for individual headers like we do for the Google project header
on line 90 above. But I won't die on this hill either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
