PhillHenry commented on code in PR #3729:
URL: https://github.com/apache/polaris/pull/3729#discussion_r3021461153
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/iceberg/IcebergRestConnectionConfigInfoDpo.java:
##########
@@ -43,19 +43,34 @@
public class IcebergRestConnectionConfigInfoDpo extends ConnectionConfigInfoDpo
implements IcebergCatalogPropertiesProvider {
+ private static final String GOOGLE_USER_PROJECT_HEADER_KEY =
"x-goog-user-project";
+
private final String remoteCatalogName;
+ @Nullable private final Map<String, String> configs;
+
+ /**
+ * @param configs Properties that might be specifically needed for a
particular implementation of
+ * a REST API.
+ */
public IcebergRestConnectionConfigInfoDpo(
@JsonProperty(value = "uri", required = true) @Nonnull String uri,
@JsonProperty(value = "authenticationParameters", required = true)
@Nonnull
AuthenticationParametersDpo authenticationParameters,
@JsonProperty(value = "serviceIdentity", required = false) @Nullable
ServiceIdentityInfoDpo serviceIdentityInfo,
@JsonProperty(value = "remoteCatalogName", required = false) @Nullable
- String remoteCatalogName) {
+ String remoteCatalogName,
+ @JsonProperty(value = "configs", required = false) @Nullable Map<String,
String> configs) {
super(
ConnectionType.ICEBERG_REST.getCode(), uri, authenticationParameters,
serviceIdentityInfo);
this.remoteCatalogName = remoteCatalogName;
+ this.configs = configs;
Review Comment:
Changed to additionalHeaders after a suggestion by @adutra above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
