gh-yzou commented on code in PR #3729:
URL: https://github.com/apache/polaris/pull/3729#discussion_r3012406390
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/iceberg/IcebergRestConnectionConfigInfoDpo.java:
##########
@@ -100,6 +125,7 @@ public ConnectionConfigInfo asConnectionConfigInfoModel(
serviceIdentityInfoDpo ->
serviceIdentityInfoDpo.asServiceIdentityInfoModel(serviceIdentityProvider))
.orElse(null))
+ .setAdditionalHeaders(getConfigs())
Review Comment:
I think the ideas is that not all configs needs be headers, right now we
only have GOOGLE_USER_PROJECT_HEADER_KEY which is a header, but in the future
any configs doesn't fit with other field definition could be added to configs
for simple extension.
I believe here we want to call setConfigs instead of setAdditionalHeaders
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
