huaxingao commented on code in PR #4269:
URL: https://github.com/apache/polaris/pull/4269#discussion_r3214267924
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -573,4 +573,72 @@ public static void enforceFeatureEnabledOrThrow(
+ "configured, but existing values cannot be changed to
different ones.")
.defaultValue(false)
.buildFeatureConfiguration();
+
+ public static final FeatureConfiguration<Boolean> IDEMPOTENCY_ENABLED =
+ PolarisConfiguration.<Boolean>builder()
+ .key("IDEMPOTENCY_ENABLED")
+ .catalogConfig("polaris.config.idempotency.enabled")
+ .description(
+ "Master switch for handler-level idempotency. When true (and an
Idempotency-Key "
+ + "header is present), supported handler methods (initially
createTableDirect) "
+ + "reserve the key after authorization and rebuild the
response from "
+ + "authoritative state on replay. May be overridden
per-catalog so that a "
+ + "specific catalog can opt in or out of idempotency without
changing the "
+ + "realm-wide setting.")
+ .defaultValue(false)
+ .buildFeatureConfiguration();
+
+ public static final FeatureConfiguration<Long> IDEMPOTENCY_TTL_MILLIS =
Review Comment:
Moved them off `FeatureConfiguration` into `IdempotencyConfiguration` as
system-wide settings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
