huaxingao commented on PR #4269:
URL: https://github.com/apache/polaris/pull/4269#issuecomment-4436170701
Thanks @dimas-b! I went with your suggestion. Pushed an update that:
- Removes `IdempotencyPersistence` from `BasePersistence`'s extends list.
- Adds `getOrCreateIdempotencyPersistence` to `MetaStoreManagerFactory`,
implemented per backend (`JDBC returns the JdbcBasePersistenceImpl`, in-memory
returns a per-realm I`nMemoryIdempotencyPersistence`, NoSQL throws
`UnsupportedOperationException`).
- `IdempotencyHandlerSupport` and `IdempotencyMaintenance` now go through
the new typed factory accessor instead of `getOrCreateSession`.
This stays in the same direction as #4397 but is scoped narrowly to the
idempotency SPI. PTAL. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
