dimas-b commented on PR #4269: URL: https://github.com/apache/polaris/pull/4269#issuecomment-4435577601
@huaxingao : my comments above still stand. I believe can do better in this PR, which is why I'm not approving. Merging #4397 first would work fine, but it might be a rather big effort end-to-end. As far as this PR is concerned, from my POV it would be sufficient to remove `IdempotencyPersistence` from `BasePersistence` and implement related factory changes for proper wiring. I do believe this would be a smaller change but it would move in the same direction as #4397. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
