huaxingao commented on code in PR #4397:
URL: https://github.com/apache/polaris/pull/4397#discussion_r3230617112


##########
persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/NoSqlMetaStoreManagerFactory.java:
##########
@@ -132,7 +132,7 @@ public EntityCache getOrCreateEntityCache(RealmContext 
realmContext, RealmConfig
   }
 
   @Override
-  public BasePersistence getOrCreateSession(RealmContext realmContext) {
+  public BasePersistence getOrCreateBasePersistence(RealmContext realmContext) 
{

Review Comment:
   Happy to split if you'd prefer. I kept it in this PR because Dennis asked 
for the rename in his mailing-list reply.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to