dimas-b commented on code in PR #4397:
URL: https://github.com/apache/polaris/pull/4397#discussion_r3235147044
##########
persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/NoSqlMetaStoreManagerFactory.java:
##########
@@ -132,7 +132,7 @@ public EntityCache getOrCreateEntityCache(RealmContext
realmContext, RealmConfig
}
@Override
- public BasePersistence getOrCreateSession(RealmContext realmContext) {
+ public BasePersistence getOrCreateBasePersistence(RealmContext realmContext)
{
Review Comment:
If you do not mind, let's do the rename separately and before this PR - it
is a non-controversial rename - easy to review and approve :) then this (more
difficult) PR will have a small diff (after rebasing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
