huaxingao commented on code in PR #4397:
URL: https://github.com/apache/polaris/pull/4397#discussion_r3237896340
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/MetaStoreManagerFactory.java:
##########
@@ -34,6 +35,13 @@ public interface MetaStoreManagerFactory {
BasePersistence getOrCreateSession(RealmContext realmContext);
+ /**
+ * Returns the per-realm {@link MetricsPersistence}. This SPI is decoupled
from {@link
+ * BasePersistence} so backends that do not implement metrics persistence
can simply return a
+ * no-op instance.
+ */
+ MetricsPersistence getOrCreateMetricsPersistence(RealmContext realmContext);
Review Comment:
Thanks for the suggestion! I'd prefer to keep this abstract. @dimas-b 's
earlier comment on the NoSQL override asked for an explicit `new
MetricsPersistence() {}` "for the sake of clarity", my read is we should avoid
a factory-level default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
