dimas-b commented on code in PR #4269: URL: https://github.com/apache/polaris/pull/4269#discussion_r3243550690
########## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/idempotency/RelationalJdbcIdempotencyStore.java: ########## @@ -1,250 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package org.apache.polaris.persistence.relational.jdbc.idempotency; - -import jakarta.annotation.Nonnull; -import java.sql.ResultSet; -import java.sql.SQLException; -import java.sql.Timestamp; -import java.time.Instant; -import java.util.HashMap; -import java.util.LinkedHashMap; -import java.util.List; -import java.util.Map; -import java.util.Optional; -import java.util.Set; -import javax.sql.DataSource; -import org.apache.polaris.core.entity.IdempotencyRecord; -import org.apache.polaris.core.persistence.IdempotencyPersistenceException; -import org.apache.polaris.core.persistence.IdempotencyStore; -import org.apache.polaris.persistence.relational.jdbc.DatasourceOperations; -import org.apache.polaris.persistence.relational.jdbc.QueryGenerator; -import org.apache.polaris.persistence.relational.jdbc.RelationalJdbcConfiguration; -import org.apache.polaris.persistence.relational.jdbc.models.Converter; -import org.apache.polaris.persistence.relational.jdbc.models.ModelIdempotencyRecord; - -public class RelationalJdbcIdempotencyStore implements IdempotencyStore { Review Comment: My point that co-locating Idempotency methods in the same class as MetaStore methods for JDBC does not help or harm transactional processing. What matters is the JDBC `Connection` (which carries the Tx state). In this PR, the Idempotency `reserve` method (as an example), uses a separate `Connection` and commits before exiting. With this approach it might as well exist in a separate class (to avoid bloating one class with all new functionality). That said, removing `RelationalJdbcIdempotencyStore` is not a blocker for this PR from my POV. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
