dimas-b commented on code in PR #4269:
URL: https://github.com/apache/polaris/pull/4269#discussion_r3243129854


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/MetaStoreManagerFactory.java:
##########
@@ -34,6 +34,14 @@ public interface MetaStoreManagerFactory {
 
   BasePersistence getOrCreateSession(RealmContext realmContext);
 
+  /**
+   * Returns the per-realm {@link IdempotencyPersistence}. Implementations are 
free to back this
+   * with the same storage as {@link #getOrCreateSession(RealmContext)} or 
with a different one
+   * (e.g. an in-memory store for dev mode). Backends that do not support 
handler-level idempotency
+   * should throw {@link UnsupportedOperationException}.
+   */
+  IdempotencyPersistence getOrCreateIdempotencyPersistence(RealmContext 
realmContext);

Review Comment:
   After today's Community Sync discussion, I do not think this is a blocker.
   
   I still think we can have cleaner SPI definitions between this factory and 
persistence interfaces, but that can be done later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to