dennishuo commented on code in PR #4269:
URL: https://github.com/apache/polaris/pull/4269#discussion_r3243524697
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/MetaStoreManagerFactory.java:
##########
@@ -34,6 +34,14 @@ public interface MetaStoreManagerFactory {
BasePersistence getOrCreateSession(RealmContext realmContext);
+ /**
+ * Returns the per-realm {@link IdempotencyPersistence}. Implementations are
free to back this
+ * with the same storage as {@link #getOrCreateSession(RealmContext)} or
with a different one
+ * (e.g. an in-memory store for dev mode). Backends that do not support
handler-level idempotency
+ * should throw {@link UnsupportedOperationException}.
+ */
+ IdempotencyPersistence getOrCreateIdempotencyPersistence(RealmContext
realmContext);
Review Comment:
+1, we might be missing a concrete stance on what we even mean by
"Metastore" ;)
On the one hand, we could take it to mean specifically the single physical
backend that stores `BasePersistence` concerns (`PolarisEntity`).
On the other hand, it could mean "the bag of all persistence-related things".
At least starting with just multiplexing out of here isn't a one-way door,
so I agree with iterating on cleaner SPI definitions in a followup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
