adutra commented on PR #4620: URL: https://github.com/apache/polaris/pull/4620#issuecomment-4631310896
Hi @vigneshio thank you for this PR! I agree that in principle, it's cleaner to instantiate the verifier in the constructor. But as you said, the token broker is a request-scoped bean. As such, I'm not sure that this change improves the efficiency of this area of code: you are still creating one verifier per request. You would need instead to create the verifier in the `TokenBrokerFactory` in order to save repeated memory allocations for the verifier. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
