vigneshio commented on code in PR #4620:
URL: https://github.com/apache/polaris/pull/4620#discussion_r3382657699


##########
runtime/service/src/test/java/org/apache/polaris/service/auth/internal/broker/JWTSymmetricKeyGeneratorTest.java:
##########
@@ -70,4 +71,37 @@ public void testJWTSymmetricKeyGenerator() {
     
assertThat(decodedJWT.getClaim("scope").asString()).isEqualTo("PRINCIPAL_ROLE:TEST");
     
assertThat(decodedJWT.getClaim("client_id").asString()).isEqualTo(clientId);
   }
+
+  /** Verify that the same broker instance can verify a token multiple times. 
*/
+  @Test
+  public void testMultipleVerificationsWithSameBroker() {

Review Comment:
   That's fair. The test wasn't specifically verifying the behavior introduced 
by this change and would have passed before as well. I've removed it..  The 
generator tests still cover the broker, and the per-realm reuse is handled by 
**computeIfAbsent** in the factory.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to